Integrated: 8309502: RISC-V: String.indexOf intrinsic may produce misaligned memory loads
Vladimir Kempik
vkempik at openjdk.org
Thu Jun 15 06:25:11 UTC 2023
On Mon, 5 Jun 2023 20:52:01 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:
> Please review this attempt to remove misaligned loads in String.indexOf intrinsic on RISC-V
>
> Initialy found these misaligned loads when profiling finagle-http test from renaissance suite.
> The majority of trp_lam events (about 66k per finagle-http round) came at line 706 (https://github.com/openjdk/jdk/pull/14320/files#diff-35eb1d2f1e2f0514dd46bd7fbad49ff2c87703d5a3041a6433956df00a3fe6e6L706)
> The other two produced about 100 events combined.
> Later I've found this can partially be reproduced with StringIndexOf.advancedWithMediumSub.
> Numbers on hifive before and after applying the patch:
>
>
> Benchmark Mode Cnt Score Error Units
> StringIndexOf.advancedWithMediumSub avgt 25 47031.406 ± 144.005 ns/op
>
>
> After:
>
> Benchmark Mode Cnt Score Error Units
> StringIndexOf.advancedWithMediumSub avgt 25 4256.830 ± 23.075 ns/op
>
>
> Testing: tier1/tier2 is clean on hifive.
This pull request has now been integrated.
Changeset: 6b942893
Author: Vladimir Kempik <vkempik at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/6b942893868fa1a64977288bdbdb1bbff8bd9d9c
Stats: 84 lines in 3 files changed: 67 ins; 5 del; 12 mod
8309502: RISC-V: String.indexOf intrinsic may produce misaligned memory loads
Reviewed-by: luhenry, fjiang, fyang
-------------
PR: https://git.openjdk.org/jdk/pull/14320
More information about the hotspot-compiler-dev
mailing list