RFR: 8310126: C1: Missing receiver null check in Reference::get intrinsic

Aleksey Shipilev shade at openjdk.org
Fri Jun 16 10:13:00 UTC 2023


On Fri, 16 Jun 2023 09:28:38 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> We crash in C1 compiled code due a missing null check on the argument of the `Reference::get` method. The problem is that after [JDK-8201543](https://bugs.openjdk.org/browse/JDK-8201543), see [here](https://hg.openjdk.org/jdk/jdk/rev/4bb58f644e4e#l43.46), no `CodeEmitInfo` is passed to `access_load_at` and therefore no implicit null check is emitted.
> 
> Thanks,
> Tobias

Looks fine. Seems to be the only place where it is missing.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14511#pullrequestreview-1483153243


More information about the hotspot-compiler-dev mailing list