RFR: 8310143: RandomCommandsTest fails due to unexpected VM exit code after JDK-8282797
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Fri Jun 16 15:24:01 UTC 2023
On Fri, 16 Jun 2023 10:28:12 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
> The fix for [JDK-8282797](https://bugs.openjdk.org/browse/JDK-8282797) missed that randomly generated Compile Commands can be invalid. I verified with the corresponding seeds that all occurrences of this intermittent failure are now fixed.
>
> Thanks,
> Tobias
test/hotspot/jtreg/compiler/compilercontrol/share/MultiCommand.java line 83:
> 81: } else {
> 82: md = AbstractTestBase.METHOD_GEN.generateRandomDescriptor(exec);
> 83: isValid = false;
Is there a (remote) chance that `generateRandomDescriptor()` generates a valid descriptor? Would the compiler control test fail in that case due to a "false negative" ("expected to fail but did not fail")? Maybe a clarifying comment here would help.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14514#discussion_r1232393843
More information about the hotspot-compiler-dev
mailing list