RFR: 8291003: ARM32: constant_table.size assertion [v2]

[TheFarlandsExplorer15]

On Thu, 28 Jul 2022 19:47:34 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:

>> This change fixes assertion condition as per the recent [JDK-8287373](https://bugs.openjdk.org/browse/JDK-8287373) change: the size of constants section is aligned up according to the settings of the next section (instructions section).
>
> Boris Ulasevich has updated the pull request incrementally with one additional commit since the last revision:
> 
>   align_at_start api clarification, use explicit section index in the expression

src/hotspot/cpu/arm/arm.ad line 239:

> 237:   Register r = as_Register(ra_->get_encode(this));
> 238:   CodeSection* consts_section = __ code()->consts();
> 239:   int consts_size = consts_section->align_at_start(consts_section->size());

-     int consts_size = consts_section->align_at_start(consts_section->size());
I have no idea what that means and:
+    // constants section size is aligned according to the align_at_start settings of the next section
And it is: int consts_size = CodeSection::align_at_Start(consts_section->size(), CodeBuffer::SECT_INSTS);
Still no idea.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/9672#discussion_r1233383234