Integrated: 8309601: [JVMCI] AMD64#getLargestStorableKind returns incorrect mask kind

Gergö Barany gbarany at openjdk.org
Mon Jun 19 02:31:16 UTC 2023


On Tue, 13 Jun 2023 08:24:23 GMT, Gergö Barany <gbarany at openjdk.org> wrote:

> `jdk.vm.ci.amd64.AMD64#getLargestStorableKind(RegisterCategory)` unconditionally returns `AMD64Kind.MASK64` for mask registers. This is only correct if the target supports AVX512BW. On other AVX512 versions this should be `MASK16`.
> 
> The Graal compiler uses this method to determine how to spill a given register. An incorrect size will lead to compilation errors due to trying to emit a move with a size that is not supported by the target. I have manually verified that this fixes those problems.

This pull request has now been integrated.

Changeset: 492d25c8
Author:    Gergö Barany <gbarany at openjdk.org>
Committer: Tom Rodriguez <never at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/492d25c8df0f818d6f6e3a18a82bfad8fa95c282
Stats:     11 lines in 1 file changed: 9 ins; 0 del; 2 mod

8309601: [JVMCI] AMD64#getLargestStorableKind returns incorrect mask kind

Reviewed-by: dnsimon, never

-------------

PR: https://git.openjdk.org/jdk/pull/14441


More information about the hotspot-compiler-dev mailing list