RFR: JDK-8309266: C2: assert(final_con == (jlong)final_int) failed: final value should be integer [v3]

[Eric Nothum]

On Mon, 19 Jun 2023 12:25:30 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> Eric Nothum has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>    JDK-8309266: reverted previous changes. assert was adapted and in case of overflow bottom is now returned
>
> src/hotspot/share/opto/loopnode.cpp line 2316:
> 
>> 2314:     // Assert checks for overflow only if all input nodes are ConINodes, as during CCP
>> 2315:     // there might be a temporary overflow from PhiNodes see JDK-8309266
>> 2316:     assert(in(Init)->is_ConI() && in(Limit)->is_ConI() && in(Stride)->is_ConI() \
> 
> Do we really need a backslash here?

No not really, I just thought the line was getting long

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14490#discussion_r1234008854