RFR: 8310143: RandomCommandsTest fails due to unexpected VM exit code after JDK-8282797 [v2]

[Roberto Castañeda Lozano]

On Mon, 19 Jun 2023 12:51:54 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> The fix for [JDK-8282797](https://bugs.openjdk.org/browse/JDK-8282797) missed that randomly generated Compile Commands can be invalid. I verified with the corresponding seeds that all occurrences of this intermittent failure are now fixed. I also removed `Executor::isValid` because it's unused.
>> 
>> Thanks,
>> Tobias
>
> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Missed another usage of Executor constructor

Thanks for addressing my question! Changes in `MultiCommand.java` look good.

Marked as reviewed by rcastanedalo (Reviewer).

test/hotspot/jtreg/compiler/compilercontrol/share/scenario/Executor.java line 65:

> 63:      */
> 64:     public Executor(List<String> vmOptions, Map<Executable, State> states,
> 65:                     List<String> jcmdCommands) {

`compiler.compilercontrol.jcmd.StressAddJcmdBase` extends `Executor`, so its constructor needs to be updated.

-------------

Changes requested by rcastanedalo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14538#pullrequestreview-1486154925
PR Review: https://git.openjdk.org/jdk/pull/14538#pullrequestreview-1486161829
PR Review Comment: https://git.openjdk.org/jdk/pull/14538#discussion_r1234014073