RFR: 8309109: AArch64: [TESTBUG] compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java fails on Neoverse N2 and V1 [v2]

Hao Sun haosun at openjdk.org
Wed Jun 21 02:55:31 UTC 2023


On Tue, 20 Jun 2023 08:35:02 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Hao Sun has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comment
>
> test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java line 31:
> 
>> 29:  * @library /test/lib /
>> 30:  * @requires vm.flagless
>> 31:  * @requires os.arch == "aarch64" & os.family == "mac"
> 
> I think this requires a comment. Something to the effect that we don't always enable the use of SHA3 instructions because they don't always help.

Agree. Updated in the latest commit.
Would you mind taking another look? Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14551#discussion_r1236220561


More information about the hotspot-compiler-dev mailing list