RFR: 8308780: Fix the Java Integer types on Windows [v9]

Julian Waters jwaters at openjdk.org
Fri Jun 23 00:16:13 UTC 2023


On Thu, 22 Jun 2023 19:37:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp line 1084:
>> 
>>> 1082: 
>>> 1083:             jint *colorBits = nullptr;
>>> 1084:             int *maskBits = nullptr;
>> 
>> Suggestion:
>> 
>>             jint *colorBits = NULL;
>>             int *maskBits = NULL;
>> 
>> I'd rather keep `NULL` — it's used consistently inside `_Win32ShellFolder2_getIconBits` function as well as through the file, so `nullptr` is out of place.
>
> The type of `colorBits` is `jint` because it's set to `iconBits` array, right?

Yes, colorBits is a jint because of that

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14125#discussion_r1239143202


More information about the hotspot-compiler-dev mailing list