RFR: 8307625: Redundant receiver null check in LibraryCallKit::generate_method_call [v2]

[Tobias Hartmann]

On Mon, 26 Jun 2023 07:36:10 GMT, Eric Nothum <duke at openjdk.org> wrote:

>> The null_check_receiver() calls in generate_method_call are redundant as all callers of generate_method_call already perform this check. For future uses of generate_method_call a new assert is introduced that fails if the caller does not null check the receiver.
>> Also generally null_check_receiver() should be combined with stopped(), which was not the case here.
>
> Eric Nothum has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8307625: moved declaration of t inside the assert to avoid dead code in the product version.

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14542#pullrequestreview-1498024884