RFR: 8310264: In PhaseChaitin::Split defs and phis are leaked [v4]

[Johan Sjölen]

On Fri, 23 Jun 2023 07:03:49 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Be conservative in sizing to be close to original behavior
>
> src/hotspot/share/opto/reg_split.cpp line 575:
> 
>> 573:   // Keep track of DEFS & Phis for later passes
>> 574:   Node_List defs{split_arena, 8};
>> 575:   Node_List phis{split_arena, 16};
> 
> Why do you use aggregate initialization instead of constructor invocation here?

This will call the constructor, and has since C++11 I believe.  However, I'm clearly being inconsistent here and with the VectorSet change above. There's no reason that I picked brace initializer other than it being the 'modern' way: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-list

I'll revert this change and use regular parens to be more stylistically consistent.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14530#discussion_r1242001442