Integrated: JDK-8310425: [JVMCI] compiler/runtime/TestConstantDynamic: lookupConstant returned an object of incorrect type: null

David Leopoldseder davleopo at openjdk.org
Tue Jun 27 08:33:12 UTC 2023


On Wed, 21 Jun 2023 10:26:19 GMT, David Leopoldseder <davleopo at openjdk.org> wrote:

> Fix JVMCI handling of null dynamic constants and dynamic constant errors.
> 
> For null dynamic constants, the JVMCI code was checking for `Universe::the_null_sentinel` but `ConstantPool::resolve_possibly_cached_constant_at` returns `nullptr` for null constants.
> 
> In the case of errors thrown by a bootstrap method, `ConstantPool::resolve_possibly_cached_constant_at` already propagates the `BootstrapMethodError` so there's no need to check for `tag.is_dynamic_constant_in_error()`.

This pull request has now been integrated.

Changeset: 15878360
Author:    David Leopoldseder <davleopo at openjdk.org>
Committer: Doug Simon <dnsimon at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/15878360bf22c88a6e4038f05efa6db08d72b309
Stats:     14 lines in 2 files changed: 10 ins; 0 del; 4 mod

8310425: [JVMCI] compiler/runtime/TestConstantDynamic: lookupConstant returned an object of incorrect type: null

Reviewed-by: dnsimon, never

-------------

PR: https://git.openjdk.org/jdk/pull/14582


More information about the hotspot-compiler-dev mailing list