RFR: 8309209: C2 failed "assert(_stack_guard_state == stack_guard_reserved_disabled) failed: inconsistent state"

[David Holmes]

On Tue, 27 Jun 2023 07:29:21 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> This appears to be the same kind of issue as reported in [JDK-8146697](https://bugs.openjdk.org/browse/JDK-8146697) way back in Java 9, which was only "fixed" on x86.  The current failure was seen on Aarch64. It seems prudent to apply the same changes to all the other platforms. I've done Aarch64, and took a guess at RISC-V but do not know PPC or S390, so I am looking to others to provide the appropriate equivalent code changes there.
>> 
>> Testing so far is Aarch64 only:
>> - Tiers 1-3
>> - 50x the closed stackoverflow test that failed previously
>> - 25x vmTestbase/nsk/stress/stack/*
>> 
>> As these failures are so rare, passing tests don't really tell us much. This is more an attempt at additional robustness.
>> 
>> Thanks.
>
> Looks good to me as well. Maybe @offamitkumar (S390), @TheRealMDoerr (PPC), @RealFYang (RISC-V), @bulasevich (ARM32) could help with the implementation / testing on the other platforms.

Thanks @TobiHartmann for the review. Note there is no arm32 version here as for some reason it does not have the reserved stack access support, at least in this area.

@RealFYang - thanks for that I will apply your change.

@TheRealMDoerr - thanks for PPC code. I will look into the issue with using the enum as for x64.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14669#issuecomment-1609381942