RFR: 8309209: C2 failed "assert(_stack_guard_state == stack_guard_reserved_disabled) failed: inconsistent state" [v3]

[Fei Yang]

On Wed, 28 Jun 2023 02:38:25 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> This appears to be the same kind of issue as reported in [JDK-8146697](https://bugs.openjdk.org/browse/JDK-8146697) way back in Java 9, which was only "fixed" on x86.  The current failure was seen on Aarch64. It seems prudent to apply the same changes to all the other platforms. I've done Aarch64, and took a guess at RISC-V but do not know PPC or S390, so I am looking to others to provide the appropriate equivalent code changes there.
>> 
>> Testing so far is Aarch64 only:
>> - Tiers 1-3
>> - 50x the closed stackoverflow test that failed previously
>> - 25x vmTestbase/nsk/stress/stack/*
>> 
>> As these failures are so rare, passing tests don't really tell us much. This is more an attempt at additional robustness.
>> 
>> Thanks.
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update to 32-bit load and sub

src/hotspot/cpu/riscv/interp_masm_riscv.cpp line 768:

> 766: 
> 767:     // check if already enabled - if so no re-enabling needed
> 768:     ldw(t0, Address(xthread, JavaThread::stack_guard_state_offset()));

It's `lw` instead of `ldw`. See my previous comment. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14669#discussion_r1244616187