Integrated: 8307625: Redundant receiver null check in LibraryCallKit::generate_method_call

Eric Nothum duke at openjdk.org
Wed Jun 28 07:28:10 UTC 2023


On Mon, 19 Jun 2023 14:13:38 GMT, Eric Nothum <duke at openjdk.org> wrote:

> The null_check_receiver() calls in generate_method_call are redundant as all callers of generate_method_call already perform this check. For future uses of generate_method_call a new assert is introduced that fails if the caller does not null check the receiver.
> Also generally null_check_receiver() should be combined with stopped(), which was not the case here.

This pull request has now been integrated.

Changeset: c3f10e84
Author:    Eric Nothum <eric.nothum at oracle.com>
Committer: Tobias Hartmann <thartmann at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/c3f10e847999ec254893de5a1a5de32fd07f715a
Stats:     3 lines in 1 file changed: 1 ins; 0 del; 2 mod

8307625: Redundant receiver null check in LibraryCallKit::generate_method_call

Reviewed-by: thartmann, chagedorn

-------------

PR: https://git.openjdk.org/jdk/pull/14542


More information about the hotspot-compiler-dev mailing list