RFR: 8295191: IR framework timeout options expect ms instead of s [v2]
Eric Nothum
duke at openjdk.org
Wed Jun 28 08:17:14 UTC 2023
On Wed, 28 Jun 2023 08:07:33 GMT, Eric Nothum <duke at openjdk.org> wrote:
>> The flags `-DTestCompilationTimeout` and `-DWaitForCompilationTimeout` expect values in ms. The example in the README was misleading as one could infer from "default: 10s" that the flag expects values in ms. Therefore I changed the values and units in the example to ms.
>
> Eric Nothum has updated the pull request incrementally with one additional commit since the last revision:
>
> Changed TestCompilationTimeout and WaitForCompilationTimeout to expect seconds
Reverted the changes in README.
Changed the code to now expect a value in seconds from the user.
The timing itself is still implemented in milliseconds, which is why I added MS to the internal variable name.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14649#issuecomment-1610968912
More information about the hotspot-compiler-dev
mailing list