RFR: 8295191: IR framework timeout options expect ms instead of s [v3]

Wed Jun 28 10:38:04 UTC 2023

On Wed, 28 Jun 2023 08:16:55 GMT, Eric Nothum <duke at openjdk.org> wrote:

>> The flags `-DTestCompilationTimeout` and `-DWaitForCompilationTimeout` expect values in ms. The example in the README was misleading as one could infer from "default: 10s" that the flag expects values in ms. Therefore I changed the values and units in the example to ms.
>
> Eric Nothum has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Revert "change s to ms in README.md"
>    
>    This reverts commit 4dc035f4b694645f9582d412a03632d4447b74e7.
>  - Revert "Update README.md"
>    
>    This reverts commit 22fbeedd1633366a0de1b673bcd57a89bf3931d3.

That looks good but you also need to update the new variable names here:
https://github.com/openjdk/jdk/blob/c3f10e847999ec254893de5a1a5de32fd07f715a/test/hotspot/jtreg/compiler/lib/ir_framework/test/CustomRunTest.java#L136-L140

-------------

Changes requested by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14649#pullrequestreview-1502793519