RFR: 8310264: In PhaseChaitin::Split defs and phis are leaked [v5]
Tobias Hartmann
thartmann at openjdk.org
Wed Jun 28 14:18:06 UTC 2023
On Wed, 28 Jun 2023 12:26:18 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> Hi,
>>
>> `defs` and `phis` are leaked as they are resource allocated but not protected by a `ResourceMark`. The intention might have been for these to also live in the `split_arena`.. This change is the most conservative one, however, and does fix the memory leak.
>>
>> Please consider, thanks.
>>
>> Johan
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>
> Revert to list init
Looks good to me too.
-------------
Marked as reviewed by thartmann (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14530#pullrequestreview-1503215193
More information about the hotspot-compiler-dev
mailing list