RFR: 8295191: IR framework timeout options expect ms instead of s [v4]

Tobias Hartmann thartmann at openjdk.org
Wed Jun 28 18:35:58 UTC 2023


On Wed, 28 Jun 2023 11:10:27 GMT, Eric Nothum <duke at openjdk.org> wrote:

>> The flags `-DTestCompilationTimeout` and `-DWaitForCompilationTimeout` expect values in ms. The example in the README was misleading as one could infer from "default: 10s" that the flag expects values in ms. Therefore I changed the values and units in the example to ms.
>
> Eric Nothum has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Changed variable name for CustomRunTest.java

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14649#pullrequestreview-1503729729


More information about the hotspot-compiler-dev mailing list