RFR: 8309209: C2 failed "assert(_stack_guard_state == stack_guard_reserved_disabled) failed: inconsistent state" [v5]

David Holmes dholmes at openjdk.org
Wed Jun 28 21:17:00 UTC 2023


On Wed, 28 Jun 2023 09:57:07 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   S390 code
>
> src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp line 698:
> 
>> 696:     // check if already enabled - if so no re-enabling needed
>> 697:     ldr(rscratch1, Address(rthread, JavaThread::stack_guard_state_offset()));
>> 698:     cmp(rscratch1, (u1)StackOverflow::stack_guard_enabled);
> 
> Not ldrw + cmpw?

I've no idea, I used the code below as the pattern here. @theRealAph reviewed this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14669#discussion_r1245777845


More information about the hotspot-compiler-dev mailing list