RFR: 8311087: PhiNode::wait_for_region_igvn should break early

Tobias Hartmann thartmann at openjdk.org
Thu Jun 29 11:23:53 UTC 2023


On Thu, 29 Jun 2023 10:44:45 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi, please consider this PR.
> 
> Instead of continuing the loop we break after setting `delay = true`. I also flattened out the indentation by transforming `A && B` into `!A || !B` and `continue`ing if so. This makes the code a bit longer, but clearer imho.
> 
> I've run `TestCastIIAfterUnrollingInOuterLoop`, which is the test that was added along with this method. I'm also running tier1.
> 
> Thanks,
> Johan

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14707#pullrequestreview-1505073276


More information about the hotspot-compiler-dev mailing list