RFR: 8310308: IR Framework: check for type and size of vector nodes [v2]

Emanuel Peter epeter at openjdk.org
Thu Jun 29 13:55:19 UTC 2023


On Wed, 28 Jun 2023 11:10:37 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert to ANY for TestAutoVectorization2DArray.java
>
> test/hotspot/jtreg/compiler/c2/TestMinMaxSubword.java line 64:
> 
>> 62:     // should not generate vectorized Min/Max nodes for them.
>> 63:     @Test
>> 64:     @IR(failOn = {IRNode.MIN_VI, IRNode.MIN_VF, IRNode.MIN_VD})
> 
> We could think about keeping generic vector nodes that match any type and restrict their usage to `failOn` constraints.

I'm not sure it is worth it now. There are very few use cases, this is one of them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14539#discussion_r1246650871


More information about the hotspot-compiler-dev mailing list