RFR: 8309531: Incorrect result with unwrapped iotaShuffle. [v4]

Jatin Bhateja jbhateja at openjdk.org
Fri Jun 30 10:32:59 UTC 2023


> Patch fixes following two issues in iotaShuffle inline expander with unwrapped indices.
>  1) Disable intrinsification if effective index do not lie within byte value range.
>  2) Use GT predicate while computing comparison mask for all the indices above vector length.
> 
> No performance degradation seen with existing slice/unslice operations which internally calls wrapped iotaShuffle.
> 
> This interim patch addresses incorrectness around iotaShuffle till we introduce modified shuffle implementations
> with JDK-8310691.
> 
> Kindly review and share feedback.
> 
> Best Regards,
> Jatin

Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:

  Review comments resolutions and test modifications.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14700/files
  - new: https://git.openjdk.org/jdk/pull/14700/files/cde4bf53..f8a5189a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14700&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14700&range=02-03

  Stats: 121 lines in 2 files changed: 54 ins; 22 del; 45 mod
  Patch: https://git.openjdk.org/jdk/pull/14700.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14700/head:pull/14700

PR: https://git.openjdk.org/jdk/pull/14700


More information about the hotspot-compiler-dev mailing list