RFR: 8309531: Incorrect result with unwrapped iotaShuffle. [v5]
Sandhya Viswanathan
sviswanathan at openjdk.org
Fri Jun 30 17:53:53 UTC 2023
On Fri, 30 Jun 2023 10:50:01 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> Patch fixes following two issues in iotaShuffle inline expander with unwrapped indices.
>> 1) Disable intrinsification if effective index do not lie within byte value range.
>> 2) Use GT predicate while computing comparison mask for all the indices above vector length.
>>
>> No performance degradation seen with existing slice/unslice operations which internally calls wrapped iotaShuffle.
>>
>> This interim patch addresses incorrectness around iotaShuffle till we introduce modified shuffle implementations
>> with JDK-8310691.
>>
>> Kindly review and share feedback.
>>
>> Best Regards,
>> Jatin
>
> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments resolutions.
Looks good to me.
-------------
Marked as reviewed by sviswanathan (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14700#pullrequestreview-1507629394
More information about the hotspot-compiler-dev
mailing list