RFR: 8294715: Add IR checks to the reduction vectorization tests [v3]

Emanuel Peter epeter at openjdk.org
Wed Mar 1 12:42:13 UTC 2023


On Wed, 1 Mar 2023 12:17:57 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Daniel Skantz has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address further review comments (edits)
>
> test/hotspot/jtreg/compiler/loopopts/superword/SumRedAbsNeg_Double.java line 97:
> 
>> 95:     @Test
>> 96:     @IR(applyIfOr = {"SuperWordReductions", "false", "LoopMaxUnroll", "< 8"},
>> 97:         failOn = {IRNode.ADD_REDUCTION_VD, IRNode.ABS_V, IRNode.NEG_V})
> 
> @danielogh Are you sure that this would not vectorize if `sve` is available? It may not fail on any Oracle test machines, but we only have `x64` and `aarch64` (only have `asimd`, not `sve`). Have you ever let this be tested explicitly with `sve` support?

@fg1417 could you please run this patch on a machine with `sve` support? It would be good to know that all IR rules are ok.

> test/hotspot/jtreg/compiler/loopopts/superword/SumRedSqrt_Double.java line 100:
> 
>> 98:     @IR(applyIfCPUFeature = {"avx", "true"},
>> 99:         applyIfAnd = {"SuperWordReductions", "true", "LoopMaxUnroll", ">= 8"},
>> 100:         counts = {IRNode.ADD_REDUCTION_VD, ">= 1", IRNode.SQRT_V, ">= 1"})
> 
> We could also remove the store to `d` here.

And all the following files as well:

SumRed_Double.java
SumRed_Float.java
SumRed_Int.java
SumRed_Long.java

-------------

PR: https://git.openjdk.org/jdk/pull/12683


More information about the hotspot-compiler-dev mailing list