RFR: JDK-8303443: IGV: Syntax highlighting and resizing for filter editor

Tobias Holenstein tholenstein at openjdk.org
Wed Mar 1 12:46:54 UTC 2023


In the Filter window of the IdealGraphVisualizer (IGV) the user can double-click on a filter to edit the javascript code. 

- Previously, the code window was not resizable and had no syntax highlighting
<img width="782" alt="editor_old" src="https://user-images.githubusercontent.com/71546117/222137737-1042b272-2c4f-4ae2-929d-2c5d285818e4.png">

- Now, the code window can be resized by the user and has basic syntax highlighting for `keywords`, `strings` and `comments`
<img width="727" alt="editor_new" src="https://user-images.githubusercontent.com/71546117/222137687-892ba36d-4a76-4769-ada7-7982ea59a5ac.png">

- Further all filter are now  saved as .js files in `src/utils/IdealGraphVisualizer/application/target/userdir/config/Filters` and reloaded when opening a new IGV instance
<img width="373" alt="js_ext" src="https://user-images.githubusercontent.com/71546117/222140304-7ab486a4-7c92-408c-9beb-10936a717fc4.png">

-------------

Commit messages:
 - IGV: Syntax highlighting and resizing for filter editor

Changes: https://git.openjdk.org/jdk/pull/12803/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12803&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8303443
  Stats: 114 lines in 2 files changed: 84 ins; 12 del; 18 mod
  Patch: https://git.openjdk.org/jdk/pull/12803.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12803/head:pull/12803

PR: https://git.openjdk.org/jdk/pull/12803


More information about the hotspot-compiler-dev mailing list