RFR: JDK-8303443: IGV: Syntax highlighting and resizing for filter editor [v2]

Tobias Holenstein tholenstein at openjdk.org
Fri Mar 3 14:45:04 UTC 2023


On Thu, 2 Mar 2023 13:57:51 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

> Thanks for improving this area of IGV!
> 
> I found a few issues in the changeset:
> 
> 1. The proposed font ("Courier") is not very readable on my system (Ubuntu Linux):
> 
> ![courier](https://user-images.githubusercontent.com/8792647/222445180-40f46bee-90e3-4b48-9d24-9571e1c4e5e8.png)
> 
> I suggest using the logical font "Monospaced" instead [for portability](https://docs.oracle.com/en/java/javase/19/docs/api/java.desktop/java/awt/Font.html):
> 
> ![monospaced](https://user-images.githubusercontent.com/8792647/222446352-49633e0f-db7c-445d-b5ae-6335b11eb95c.png)
> 
> 2. The changeset edits the generated code area of `EditFilterDialog.java`, making it out of sync with `EditFilterDialog.form`. Would it be possible to change that part of `EditFilterDialog.java` using NetBeans' GUI Builder instead? (so that `EditFilterDialog.form` stays on sync).
> 3. When I run IGV, make some change in a filter, close IGV, then re-run it again, I end up with the same filters loaded multiple times:
> 
> ![filters](https://user-images.githubusercontent.com/8792647/222448902-47a6999e-0b4a-4739-9863-3da0aaf41b86.png)

@robcasloz thanks for the feedback! I fixed 1) and 2) as suggested. 
Regarding 3) I decided to remove it from this PR. Better to add this functionality separately

-------------

PR: https://git.openjdk.org/jdk/pull/12803


More information about the hotspot-compiler-dev mailing list