RFR: 8303147: [s390x] fast & slow debug builds are broken

[SUN Guoyun]

On Fri, 3 Mar 2023 20:27:14 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> This PR fixes broken fast debug and slow debug build for s390x-arch. tier1 test are completed and results are not affect after this patch.
>
> src/hotspot/cpu/aarch64/c1_Defs_aarch64.hpp line 93:
> 
>> 91: enum {
>> 92:   pd_reserved_argument_area_size_factor = 2
>> 93: };
> 
> [Not a review, just a drive-by comment.]
> Please don't use enums to define constants like this.  This is an old and obsolete style that shouldn't be
> used any more.  Quoting from the HotSpot Style Guide:
> "Due to bugs in certain (very old) compilers, there is widespread use of enums and avoidance of in-class initialization of static integral constant members. Compilers having such bugs are no longer supported. Except where an enum is semantically appropriate, new code should use integral constants."

@kimbarrett Where to see `HotSpot Style Guide`, can you give a URL link?

-------------

PR: https://git.openjdk.org/jdk/pull/12825