RFR: 8303147: [s390x] fast & slow debug builds are broken [v2]

Amit Kumar amitkumar at openjdk.org
Mon Mar 6 08:31:04 UTC 2023


On Mon, 6 Mar 2023 07:20:37 GMT, SUN Guoyun <duke at openjdk.org> wrote:

>> Thank you. perhaps this is the difference between the S390 and other architectures, do not call store_parameter() in this method on other architectures, such as x86. 
>> 
>> LIR_Assembler::emit_typecheck_helper(LIR_OpTypeCheck*, Label*, Label*, Label*)+0x800  (c1_LIRAssembler_s390.cpp:2534)
>> 
>> Next, let's see if there is a better solution.
>
> https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp#L2534
> Maybe you can try store klass_RInfo & k_RInfo to current sp location but not  reserve_stack space. such as:
> __ z_stg(klass_RInfo, offset_in_bytes, Z_SP);

But there are other call sites as well, what about them ? You mean to change them all ?

-------------

PR: https://git.openjdk.org/jdk/pull/12825


More information about the hotspot-compiler-dev mailing list