RFR: 8298935: fix cyclic dependency bug in create_pack logic in SuperWord::find_adjacent_refs [v9]

[Emanuel Peter]

On Tue, 7 Mar 2023 11:03:18 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Hi @jatin-bhateja .
>> At Oracle we run the `compiler/loopopts/superword` and `compiler/vectorization` tests with various `AVX` and `SSE` settings, including the `UseKNLSetting`.
>> 
>> Actually, I'm against splitting the test for different platforms. Because we have a few tests that now only get executed on one platform, and the features might be rotting on other platforms without us noticing it. Also: I don't like code duplication. If someone wants to add a test, then it has to be added in multiple files. Not great.
>> 
>> My suggestion: Instead of the Scenarios, I can create multiple jtreg-test statements. Advantages:
>> 
>> 1. The can run in parallel.
>> 2. I can require platform features.
>> 3. I can have different jvm-flags for different runs.
>> 
>> That way I can make some jtreg-test statements for the `AVX / SSE` platforms (and have different `UseAVX` settings). And other jtreg-test statements for other platforms (eg. aarch64 `asimd == Neon`). But I will keep the IR rules for all platforms at the specific `@Test`.
>
> Agree, it will be better if we can run multiple IR rules on one target using UseSSE/UseAVX flags rather than having tight target dependencies.

@jatin-bhateja do your agree with the recent changes to TestDependencyOffsets.java?
Do you think the jtreg-tests are ok, with their requirements?

-------------

PR: https://git.openjdk.org/jdk/pull/12350