RFR: 8303415: Add VM_Version::is_intrinsic_supported(id)

Tobias Hartmann thartmann at openjdk.org
Wed Mar 8 18:59:39 UTC 2023


The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.

----------------------------------------------------------------------
On Wed, 8 Mar 2023 18:17:50 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> src/hotspot/share/opto/c2compiler.hpp line 68:
>> 
>>> 66:   // Check if the compiler supports an intrinsic for 'method' given the
>>> 67:   // the dispatch mode specified by the 'is_virtual' parameter.
>>> 68:   bool is_virtual_intrinsic_supported(vmIntrinsics::ID id, bool is_virtual);
>> 
>> I find the new name of the method confusing because it suggests that the intrinsic is always virtual. Can we keep the old name?
>
> We still have `is_intrinsic_supported()` declared at line 64. New `is_virtual_intrinsic_supported()` is added to handle only virtual intrinsics`_hashCode` and `_clone`.  I simply moved these intrinsics handling into separate method because it is used only by C2 in `library_call.cpp`.

Okay, got it. Thanks for the explanation.

-------------

PR: https://git.openjdk.org/jdk/pull/12858


More information about the hotspot-compiler-dev mailing list