RFR: 8302976: C2 intrinsification of Float.floatToFloat16 and Float.float16ToFloat yields different result than the interpreter [v4]

Vladimir Kozlov kvn at openjdk.org
Wed Mar 8 22:54:19 UTC 2023


On Wed, 8 Mar 2023 22:27:31 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove RISC-V port code for float16 intrinsics
>
> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 3534:
> 
>> 3532:   __ leave(); // required for proper stackwalking of RuntimeStub frame
>> 3533:   __ ret(0);
>> 3534: 
> 
> Do we really need to set up a stack frame for these two?  This should be a leaf, and we have other leaf stubs that don't set up a frame.

I think you are right. These stubs are not called from compiled code, only from C++ (C2) code during compilation.
Let me test it.

-------------

PR: https://git.openjdk.org/jdk/pull/12869


More information about the hotspot-compiler-dev mailing list