RFR: 8303804: Fix some errors of If-VectorTest and CMove-VectorTest [v2]

Wang Haomin wanghaomin at openjdk.org
Thu Mar 9 01:22:14 UTC 2023


On Wed, 8 Mar 2023 14:40:35 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Wang Haomin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   compare the results with 0
>
> src/hotspot/share/adlc/output_c.cpp line 3989:
> 
>> 3987:   if (inst->captures_bottom_type(_globalNames)) {
>> 3988:     if (strncmp("MachCall", inst->mach_base_class(_globalNames), strlen("MachCall"))
>> 3989:       && strncmp("MachIf", inst->mach_base_class(_globalNames), strlen("MachIf"))) {
> 
> Maybe explicitly compare the results with 0 here for consistency with other usage of `strcmp`

Thanks for your review, DONE

-------------

PR: https://git.openjdk.org/jdk/pull/12917


More information about the hotspot-compiler-dev mailing list