RFR: 8303415: Add VM_Version::is_intrinsic_supported(id)

Vladimir Kozlov kvn at openjdk.org
Thu Mar 9 04:02:12 UTC 2023


On Thu, 9 Mar 2023 02:28:44 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Okay, got it. Thanks for the explanation.
>
> Okay but then why do we still need the parameter `is_virtual`?

@dholmes-ora  I can remove parameter if I modify caller code like next:

-    is_available = compiler != NULL && compiler->is_intrinsic_available(mh, C->directive()) &&
-                   compiler->is_virtual_intrinsic_supported(id, is_virtual);
+    is_available = compiler != NULL && compiler->is_intrinsic_available(mh, C->directive());
+    if (is_available && is_virtual) {
+      is_available = compiler->is_virtual_intrinsic_supported(id);
+    }

Will it satisfy you?

-------------

PR: https://git.openjdk.org/jdk/pull/12858


More information about the hotspot-compiler-dev mailing list