RFR: 8303804: Fix some errors of If-VectorTest and CMove-VectorTest [v2]

Quan Anh Mai qamai at openjdk.org
Thu Mar 9 04:37:14 UTC 2023


On Thu, 9 Mar 2023 03:14:20 GMT, Wang Haomin <wanghaomin at openjdk.org> wrote:

>> Rethink about it should it be `strncmp("MachCall", inst->mach_base_class(_globalNames), strlen("MachCall") + 1)` instead? Or else we could return true for nodes that have `MachCall` as a prefix.
>
> For example, `strncmp("MachCall", "MachCallStaticJavaNode", strlen("MachCall"))` , it just compare first 8 characters, the result of this `strncmp` is 0. This is the expected result, I don't understand why `strlen` +1.

@haominw Ah I understand, is this behaviour similarly expected for `MachIf`, or we want the node to exactly match here? Thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/12917


More information about the hotspot-compiler-dev mailing list