RFR: JDK-8301074: Replace NULL with nullptr in share/opto/ [v7]

Johan Sjölen jsjolen at openjdk.org
Thu Mar 9 12:15:33 UTC 2023


> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory share/opto/. Unfortunately the script that does the change isn't perfect, and so we
> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
> 
> Here are some typical things to look out for:
> 
>     No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
>     Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
>     nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
> 
> An example of this:
> 
> 
> // This function returns null
> void* ret_null();
> // This function returns true if *x == nullptr
> bool is_nullptr(void** x);
> 
> 
> Note how nullptr participates in a code expression here, we really are talking about the specific value nullptr.
> 
> Thanks!

Johan Sjölen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:

 - Merge remote-tracking branch 'origin/master' into JDK-8301074
 - Jesper's fixes
 - Merge remote-tracking branch 'origin/JDK-8301074' into JDK-8301074
 - Explicitly use 0 for null in ARM interpreter
 - Merge remote-tracking branch 'origin/master' into JDK-8301074
 - Remove trailing whitespace
 - Check for null string explicitly
 - vkozlov fixes
 - Manual review fixes
 - Fix
 - ... and 2 more: https://git.openjdk.org/jdk/compare/34a92466...8efdb67a

-------------

Changes: https://git.openjdk.org/jdk/pull/12187/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12187&range=06
  Stats: 5594 lines in 111 files changed: 1 ins; 0 del; 5593 mod
  Patch: https://git.openjdk.org/jdk/pull/12187.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12187/head:pull/12187

PR: https://git.openjdk.org/jdk/pull/12187


More information about the hotspot-compiler-dev mailing list