RFR: JDK-8301074: Replace NULL with nullptr in share/opto/ [v8]

[Johan Sjölen]

On Thu, 9 Mar 2023 14:17:14 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory share/opto/. Unfortunately the script that does the change isn't perfect, and so we
>> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
>> 
>> Here are some typical things to look out for:
>> 
>>     No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
>>     Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
>>     nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
>> 
>> An example of this:
>> 
>> 
>> // This function returns null
>> void* ret_null();
>> // This function returns true if *x == nullptr
>> bool is_nullptr(void** x);
>> 
>> 
>> Note how nullptr participates in a code expression here, we really are talking about the specific value nullptr.
>> 
>> Thanks!
>
> Johan Sjölen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits:
> 
>  - Merge remote-tracking branch 'origin/master' into JDK-8301074
>  - Merge remote-tracking branch 'origin/master' into JDK-8301074
>  - Jesper's fixes
>  - Merge remote-tracking branch 'origin/JDK-8301074' into JDK-8301074
>  - Explicitly use 0 for null in ARM interpreter
>  - Merge remote-tracking branch 'origin/master' into JDK-8301074
>  - Remove trailing whitespace
>  - Check for null string explicitly
>  - vkozlov fixes
>  - Manual review fixes
>  - ... and 3 more: https://git.openjdk.org/jdk/compare/1e9942aa...038599b9

Passes tier1. Integrating, thank you for the reviews.

-------------

PR: https://git.openjdk.org/jdk/pull/12187