RFR: 8303238: Create generalizations for existing LShift ideal transforms [v2]

[Jasmine K.]

On Thu, 9 Mar 2023 07:47:00 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Jasmine K. has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Comments from code review
>
> test/hotspot/jtreg/compiler/c2/irTests/LShiftINodeIdealizationTests.java line 122:
> 
>> 120:     @IR(failOn = { IRNode.RSHIFT })
>> 121:     @IR(counts = { IRNode.AND, "1", IRNode.LSHIFT, "1" })
>> 122:     // Checks (x >> 4) << 8 => (x << 4) & 0xFF00
> 
> Suggestion:
> 
>     // Checks ((x >> 4) & 0xFF) << 8 => (x << 4) & 0xFF00
> 
> 
> Right? Same for test8 and the corresponding long tests.

Oh, nice catch! It seems I had mistyped there.

-------------

PR: https://git.openjdk.org/jdk/pull/12734