RFR: 8294715: Add IR checks to the reduction vectorization tests [v4]

Daniel Skantz duke at openjdk.org
Fri Mar 10 14:34:14 UTC 2023


On Wed, 8 Mar 2023 12:40:43 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Daniel Skantz has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
>> 
>>  - Merge branch 'master' of github.com:openjdk/jdk into JDK-8294715-IR-new
>>  - Correctly reset totals in RedTest*; put debug print msgs in exception
>>  - Remove 2-unroll scenario
>>  - remove duped unrolllimit
>>  - fix typo; remove non-store case from SumRedSqrt_Double due to slow run time
>>  - Merge branch 'master' of github.com:openjdk/jdk into JDK-8294715-IR-new
>>  - Remove print statements for prints that were silenced by IR framework addition
>>  - Remove non-double stores
>>  - Revert much of last commit, and part of the first commit addressing review comments : intention is to remove all the negative tests, except for on -XX:-SuperWordReductions. Keep some comments and additional IR nodes added to existing checks.
>>  - Address further review comments (edits)
>>  - ... and 4 more: https://git.openjdk.org/jdk/compare/3367fb96...ec02160d
>
> Looks good. Thanks again for the thorough and meticulous work, Daniel!
> 
> All `@IR` checks are either trivially negative (`@IR(applyIf = {"SuperWordReductions", "false"}, failOn = ...)`) or guarded by x86-specific features, so these changes should not cause false failures for non-x86 architectures anymore.

Thank you @robcasloz, @eme64 and @fg1417 for all the help and reviews!

-------------

PR: https://git.openjdk.org/jdk/pull/12683


More information about the hotspot-compiler-dev mailing list