RFR: 8304138: [JVMCI] Test FailedSpeculation existence before appending. [v2]

Tue Mar 14 15:34:52 UTC 2023

On Tue, 14 Mar 2023 15:28:31 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Yudi Zheng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   avoid iterating from beginning.
>
> src/hotspot/share/oops/methodData.cpp line 858:
> 
>> 856:   guarantee_failed_speculations_alive(nm, failed_speculations_address);
>> 857: 
>> 858:   cursor = failed_speculations_address;
> 
> Why not continue from `cursor` value from previous check loop?
> Can the list be modified by other threads in between?

It cannot be modified in between. Addressed in https://github.com/openjdk/jdk/pull/13022/commits/e8c7eec468b049e15bf54bac280585389935a37d by continuing from `cursor`

-------------

PR: https://git.openjdk.org/jdk/pull/13022