RFR: JDK-8303154: Investigate and improve instruction cache flushing during compilation [v3]
Damon Fenacci
duke at openjdk.org
Wed Mar 15 07:17:22 UTC 2023
On Tue, 14 Mar 2023 14:47:34 GMT, Damon Fenacci <duke at openjdk.org> wrote:
>> Damon Fenacci has updated the pull request incrementally with one additional commit since the last revision:
>>
>> JDK-8303154: remove flush in SharedRuntime::generate_i2c2i_adapters
>
> This fix includes some changes to `sharedRuntime` for multiple platforms. I could thoroughly test on x86_32/64 and aarch64 but I'd need some help testing on **ARM** and **RISCV**.
> @RealFYang could you or someone you know please run some testing for **RISCV** to make sure my change doesn't break anything? @bulasevich @shqking could I ask you the same for **ARM**?
> Thank you very much in advance for your help!
> @dafedafe as followup RFE (I don't want to add more changes to this PR) look on all uses of `masm::flush()` for **temporary** buffers. I see such uses in some other `SharedRuntime` methods: [SharedRuntime::generate_resolve_blob](https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp#L3299)
> There are may be only few but since we start fixing such cases we should finish.
Sure! Thanks for the hint @vnkozlov.
-------------
PR: https://git.openjdk.org/jdk/pull/12877
More information about the hotspot-compiler-dev
mailing list