RFR: 8299375: [PPC64] GetStackTraceSuspendedStressTest tries to deoptimize frame with invalid fp [v2]
Richard Reingruber
rrich at openjdk.org
Wed Mar 15 09:17:57 UTC 2023
On Wed, 15 Mar 2023 08:59:22 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Richard Reingruber has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Feedback Martin
>
> src/hotspot/cpu/ppc/frame_ppc.hpp line 389:
>
>> 387: void set_offset_fp(int value) { assert_on_heap(); _offset_fp = value; }
>> 388:
>> 389: // Mark a frame as not fully initialized
>
> Maybe add a comment like "Must not be used for frames in the valid back chain."?
Thanks for the feedback. I've added the comment and updated the Copyright years.
-------------
PR: https://git.openjdk.org/jdk/pull/12941
More information about the hotspot-compiler-dev
mailing list