RFR: 8304034: Remove redundant and meaningless comments in opto [v5]

[Tobias Hartmann]

On Tue, 14 Mar 2023 05:34:20 GMT, Yi Yang <yyang at openjdk.org> wrote:

>> Please help review this trivial change to remove redundant and meaningless comments in `hotspot/share/opto` directory.
>> 
>> They are either
>> 1. Repeat the function name that the function they comment for.
>> 2. Makes no sense, e.g. `//----Idealize----` 
>> 
>> And I think original CC-style code (`if( test )`,`call( arg )`) can be formatted in one go, instead of formatting the near code when someone touches them. But this may form a big patch, and it confuses code blame, so I left this work until we reach a consensus.
>> 
>> Thanks!
>
> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   restore mistakenly removed lines

Looks good to me otherwise.

src/hotspot/share/opto/compile.cpp line 2499:

> 2497: }
> 2498: 
> 2499: //---------------------------- Bitwise operation packing optimization ---------------------------

I think this should be converted to a "normal" comment.

src/hotspot/share/opto/matcher.cpp line 1606:

> 1604: 
> 1605: 
> 1606: //------------------------------Instruction Selection--------------------------

This should stay.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12995