RFR: 8303147: [s390x] fast & slow debug builds are broken [v2]

Dean Long dlong at openjdk.org
Fri Mar 17 20:19:32 UTC 2023


On Mon, 6 Mar 2023 05:58:23 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> This PR fixes broken fast debug and slow debug build for s390x-arch. tier1 test are completed and results are not affect after this patch.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use constant instead of enum

It looks like s390 implements emit_typecheck_helper in a different way than other ports.  Only s390 uses store_parameter() to write into the compiler frame slots reserved for stubs.  Other ports push the values and adjust the stack pointer.  I suggest s390 follow the example of other ports.  Either pass args in registers or push to temporary stack space.

-------------

PR: https://git.openjdk.org/jdk/pull/12825


More information about the hotspot-compiler-dev mailing list