RFR: 8302738: IGV: refine 'Simplify graph' filter
Christian Hagedorn
chagedorn at openjdk.org
Mon Mar 20 09:55:21 UTC 2023
On Thu, 9 Mar 2023 18:28:02 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
> The "Simplify graph" filter abstracts away details from the graph that are typically unnecessary for debugging or analyzing the represented program. This changeset decouples this filter into two:
>
> - "Simplify graph", which hides elements that are typically (but not always) unnecessary, and
> - "Condense graph", which makes the graph more compact without loss of information.
>
> Together, these two filters reduce the average graph size by a factor of 1.6x (nodes) and 1.9x (edges):
>
> 
>
> Besides decoupling the "Simplify graph" filter, the changeset extends its functionality by:
> - combining Bool and conversion nodes into their predecessors,
> - inlining all Parm nodes except control into their successors (this removes lots of long edges),
> - removing "top" inputs from call-like nodes,
> - inlining more source nodes (such as MachTemp and ThreadLocal) into their successors,
> - pretty-printing the labels of many inlined and combined nodes such as Bool comparisons or Catch projections (via a new filter that edits node properties), and
> - using a sparse representation of nodes with empty inputs (e.g. call-like nodes after applying "Simplify graph").
>
> The sparse input representation shows dots between non-contiguous inputs, instead of horizontal space proportional to the number of empty inputs. This helps reducing node width, which is known to improve overall layout quality:
>
> 
>
> Note that the exact input indices can still be retrieved via the incoming edge's tooltips:
>
> 
>
> The control-flow graph view is also adapted to this representation:
>
> 
>
> #### Additional improvements
>
> Additionally, this changeset:
> - ensures that the selected filter subset is applied in the order listed in the "Filter" window (this is necessary for combining effectively the "Simplify graph" and "Condense graph" filters, but is also generally desirable for simplicity and consistency),
> - introduces a complementary filter "Show custom node info" (enabled by default) that extends the labels of call and exception-creation nodes with custom information,
> - extends the search functionality so that combined and inlined nodes can also be searched on and selected, and
> - defines and documents JavaScript helpers to simplify the new and existing available filters.
>
> Here is an example of the effect of the new "Show custom node info" filter:
>
> 
>
> ### Testing
>
> #### Functionality
>
> - Tested the functionality manually on a small selection of graphs.
>
> - Tested automatically that viewing thousands of graphs in the three views with different filter subsets enabled does not trigger any assertion failure (by instrumenting IGV to view graphs as they are loaded and running `java -Xcomp -XX:-TieredCompilation -XX:PrintIdealGraphLevel=4`).
>
> #### Performance
>
> Measured the combined filter application and view creation time for the sea-of-nodes view on a selection of 100 medium-sized graphs (200-500 nodes). On average, applying the new "Show custom node info" filter introduces a minimal overhead of around 1%, which motivates enabling it by default. Applying the "simplify graph" and "condense graph" on top actually gives a speedup of about 12%, since the additional filter application time is amortized by laying out and drawing fewer nodes. However, these filters are not enabled by default, since they cause a (minor) loss of information which is not desirable in every use case.
>
> The graph size reduction and performance results are [attached](https://github.com/openjdk/jdk/files/10934804/performance-evaluation.ods) (note that each time measurement in the sheet corresponds to the median of ten runs).
First of all, nice work! The improved filters and the additional node info for call and exception-creation nodes is very useful. Maybe the node info can be improved further in a future RFE, for example for `CountedLoop` nodes to also show if it is a pre/main/post loop or to add the stride.
I've tried your patch out and it works quite well. But I've noticed some things:
- When selecting a `CallStaticJava` node, the custom node info is sometimes cut depending on the zoom level (sometimes more, sometimes less):
- Selecting an inlined node with the condensed graph filter does not work when searching for it. For example, I can search for `165 Bool` node in the search field. It finds it but when clicking on it, it shows me an empty graph. I would have expected to see the following graph with the "outer" node being selected which includes `165 Bool`:
- I've only just noticed this now: When having IGV opened on my second, larger monitor (ultra-wide, 3440x1440), the tooltip is quite off:
But this was already a problem before and unrelated to your patch.
I'll also have a look at the code later but I'm not very familiar with it.
Thanks,
Christian
-------------
PR: https://git.openjdk.org/jdk/pull/12955
More information about the hotspot-compiler-dev
mailing list