RFR: 8304387: Fix positions of shared static stubs / trampolines [v2]

Xiaolin Zheng xlinzheng at openjdk.org
Mon Mar 20 12:08:18 UTC 2023


On Mon, 20 Mar 2023 10:31:56 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Andrew's review comments: another cleanup
>
> src/hotspot/share/asm/codeBuffer.cpp line 1012:
> 
>> 1010: }
>> 1011: 
>> 1012: bool CodeBuffer::finalize_stubs() {
> 
> It's not actually relevant to this fix but it might be worth making a small change here. There is actually no need to call `pd_finalize_stubs` if `_finalize_stubs` is already false. So, you could return straight away if it is already false.

Thanks for the quick review, Andrew. Yes you are right. Tested a simple AArch64 tier1 and some tests for zero.

For backends excluding x86, AArch64 and RISC-V, `CodeBuffer::supports_shared_stubs()` are all false and there are no shared trampolines implemented, so `_finalize_stubs` is always a false value.

-------------

PR: https://git.openjdk.org/jdk/pull/13071


More information about the hotspot-compiler-dev mailing list