RFR: 8302738: IGV: refine 'Simplify graph' filter
Christian Hagedorn
chagedorn at openjdk.org
Mon Mar 20 12:30:28 UTC 2023
On Mon, 20 Mar 2023 12:10:35 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:
> > I'll also have a look at the code later but I'm not very familiar with it.
>
> > First of all, nice work! The improved filters and the additional node info for call and exception-creation nodes is very useful. Maybe the node info can be improved further in a future RFE, for example for `CountedLoop` nodes to also show if it is a pre/main/post loop or to add the stride.
> > I've tried your patch out and it works quite well. But I've noticed some things:
> >
> > * When selecting a `CallStaticJava` node, the custom node info is sometimes cut depending on the zoom level (sometimes more, sometimes less):
> > 
> > * Selecting an inlined node with the condensed graph filter does not work when searching for it. For example, I can search for `165 Bool` node in the search field. It finds it but when clicking on it, it shows me an empty graph. I would have expected to see the following graph with the "outer" node being selected which includes `165 Bool`:
> > 
> > * I've only just noticed this now: When having IGV opened on my second, larger monitor (ultra-wide, 3440x1440), the tooltip is quite off:
> > 
> > But this was already a problem before and unrelated to your patch.
> >
> > I'll also have a look at the code later but I'm not very familiar with it.
> > Thanks, Christian
>
> Hi Christian, Regarding tooltips on large monitors, I think this is an issue of `Netbeans Platform` that we are using in IGV. Perhaps we can upgrade to a newer version of `Netbeans Platform`
Thanks for your answer Toby! I see, that might help to fix this issue. But it's just a detail that I've noticed now when trying out the tooltips for the new inlined nodes.
-------------
PR: https://git.openjdk.org/jdk/pull/12955
More information about the hotspot-compiler-dev
mailing list