Integrated: 8304230: LShift ideal transform assertion

Tue Mar 21 06:05:53 UTC 2023

On Wed, 15 Mar 2023 18:24:23 GMT, Jasmine Karthikeyan <duke at openjdk.org> wrote:

> Hi,
> This PR aims to address the assertion on arm32 where the special-case `add1->in(2) == in(2)` check fails, and it falls through to the regular cases. I'm not quite sure how this issue can manifest as AFAIK the GVN should allow the usage of `==` to check against constants that are equal. I've changed the check from node equality to constant equality to hopefully resolve this. I unfortunately cannot reproduce the behavior on x86, nor do I have access to arm32 hardware, so I would greatly appreciate reviews and help testing this change (cc @bulasevich). Thank you all in advance.

This pull request has now been integrated.

Changeset: a6b72f56
Author:    Jasmine K <25208576+SuperCoder7979 at users.noreply.github.com>
Committer: Tobias Hartmann <thartmann at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a6b72f56f56b4f33ac163e90b115d79b2b844999
Stats:     14 lines in 1 file changed: 6 ins; 6 del; 2 mod

8304230: LShift ideal transform assertion

Reviewed-by: thartmann

-------------

PR: https://git.openjdk.org/jdk/pull/13049