RFR: 8302384: Handle hsdis out-of-bound logic for RISC-V [v3]

[Xiaolin Zheng]

On Thu, 2 Mar 2023 03:37:39 GMT, Xiaolin Zheng <xlinzheng at openjdk.org> wrote:

>> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove white spaces, and use hsdis code style
>
> Uh. Sorry for the disturbance; I forgot the rule was "1 review required, with at least 1 Reviewer" in the mainline. Seems we need to wait for another proper review of this.
> 
> BTW, an issue [1] for binutils was filed yesterday to track this; though I have not got a confirmation about whether it could get fixed, and when.
> 
> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=30184

> @zhengxiaolinX : Hi, I see the fix for binutils has been committed [1]. At the same time, as a workaround for this issue, fix for [2] was also merged. Do we still need this change then? Thanks.
> 
> [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=e43d8768d909139bf5ec4a97c79a096ed28a4b08 [2] https://bugs.openjdk.org/browse/JDK-8304387

Interestingly both are at today. Although the Binutils fix seems in the range of Binutils 2.41 and Hsdis supports 2.38- currently. But with #13071 we can fortunately "bypass" this issue. Maybe in the future we still have small chances to trigger this issue if changes are made and some interesting data is stored at the end of a piece of compiled code again - but I am okay with retracting this patch, for after #13071 code in this patch can neither be triggered nor be tested, and I do not really like the platform-specific workaround as well. I think we could put off such issue until then.

Again thanks for approving this patch! @luhenry

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12551#issuecomment-1477764218