RFR: 8304450: [vectorapi] Refactor VectorShuffle implementation [v2]

[Paul Sandoz]

On Tue, 21 Mar 2023 16:11:50 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

> Apart from the mask implementation, shuffle implementation definitely has to take into consideration the element type.

Yes, the way you have implemented shuffle is tightly connected, that looks ok.

I am wondering if we can make the mask implementation more loosely coupled and modified such that it does not have to take into consideration the element type (or species) of the vector it operates on, and instead compatibility is based solely on the lane count.

Ideally it would be good to change the `VectorMask::check` method to just compare the lanes counts and not require a cast in the implementation, which i presume requires some deeper changes in C2?

What you propose seems a possible a interim step towards a more preferable API, if the performance is good.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13093#issuecomment-1478175761